-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
play kube selinux label issue #9205
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,6 +26,49 @@ spec: | |
hostname: unknown | ||
` | ||
|
||
var selinuxLabelPodYaml = ` | ||
apiVersion: v1 | ||
kind: Pod | ||
metadata: | ||
creationTimestamp: "2021-02-02T22:18:20Z" | ||
labels: | ||
app: label-pod | ||
name: label-pod | ||
spec: | ||
containers: | ||
- command: | ||
- top | ||
- -d | ||
- "1.5" | ||
env: | ||
- name: PATH | ||
value: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin | ||
- name: TERM | ||
value: xterm | ||
- name: container | ||
value: podman | ||
- name: HOSTNAME | ||
value: label-pod | ||
image: quay.io/libpod/alpine:latest | ||
name: test | ||
securityContext: | ||
allowPrivilegeEscalation: true | ||
capabilities: | ||
drop: | ||
- CAP_MKNOD | ||
- CAP_NET_RAW | ||
- CAP_AUDIT_WRITE | ||
privileged: false | ||
readOnlyRootFilesystem: false | ||
seLinuxOptions: | ||
user: unconfined_u | ||
role: system_r | ||
type: spc_t | ||
level: s0 | ||
workingDir: / | ||
status: {} | ||
` | ||
|
||
var configMapYamlTemplate = ` | ||
apiVersion: v1 | ||
kind: ConfigMap | ||
|
@@ -803,6 +846,21 @@ var _ = Describe("Podman play kube", func() { | |
|
||
}) | ||
|
||
It("podman play kube fail with custom selinux label", func() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You need to add.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sorry hadn't considered cases where selinux is not enabled, have updated the test |
||
err := writeYaml(selinuxLabelPodYaml, kubeYaml) | ||
Expect(err).To(BeNil()) | ||
|
||
kube := podmanTest.Podman([]string{"play", "kube", kubeYaml}) | ||
kube.WaitWithDefaultTimeout() | ||
Expect(kube.ExitCode()).To(Equal(0)) | ||
|
||
inspect := podmanTest.Podman([]string{"inspect", "label-pod-test", "--format", "'{{ .ProcessLabel }}'"}) | ||
inspect.WaitWithDefaultTimeout() | ||
label := inspect.OutputToString() | ||
|
||
Expect(label).To(ContainSubstring("nconfined_u:system_r:spc_t:s0")) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sorry my bad have just correct |
||
}) | ||
|
||
It("podman play kube fail with nonexistent authfile", func() { | ||
err := generateKubeYaml("pod", getPod(), kubeYaml) | ||
Expect(err).To(BeNil()) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to add this to get pass the CI:
And make sure you import
github.com/opencontainers/selinux/go-selinux
at the top.The test doesn't work on systems without selinux support like ubuntu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry hadn't considered cases where selinux is not enabled, have updated the test