Allow pods to use --net=none #9185
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
test/e2e/pod_create_test.go
Outdated
| session := podmanTest.Podman([]string{"run", "--pod", podName, ALPINE, "wget", "www.podman.io"}) | ||
| session.WaitWithDefaultTimeout() | ||
| Expect(session.ExitCode()).To(Equal(1)) | ||
| Expect(session.ErrorToString()).To(ContainSubstring("wget: bad address 'www.podman.io'")) |
There was a problem hiding this comment.
I would recommend changing this test to ip -o -4 addr This will print one network interface per line. In this case we should only have one, the loopback adapter. The current test could also fail because dns is not working.
|
would other namespaces have the same issue when shared with the host? |
|
@giuseppe What issue, specifically? Requiring a bool in the configuration to tell us to set them to Host? |
no nevermind, I thought the same issue could happen with other namespaces beside network, but that is not the case. LGTM |
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
We need an extra field in the pod infra container config. We may want to reevaluate that struct at some point, as storing network modes as bools will rapidly become unsustainable, but that's a discussion for another time. Otherwise, straightforward plumbing. Fixes containers#9165 Signed-off-by: Matthew Heon <[email protected]>
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
Needs a fresh LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
We need an extra field in the pod infra container config. We may want to reevaluate that struct at some point, as storing network modes as bools will rapidly become unsustainable, but that's a discussion for another time. Otherwise, straightforward plumbing.
Fixes #9165