Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS]build instructions for macOS #9161

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

baude
Copy link
Member

@baude baude commented Jan 29, 2021

add instructions on how to build podman on macOS.

big thanks to acui for help in getting this written down.

Fixes: #9032

Signed-off-by: baude [email protected]

add instructions on how to build podman on macOS.

big thanks to acui for help in getting this written down.

Fixes: containers#9032

Signed-off-by: baude <[email protected]>
@baude baude requested a review from ashley-cui January 29, 2021 18:14
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2021
@rhatdan
Copy link
Member

rhatdan commented Jan 29, 2021

LGTM, it would be nice to make the Makefile smarter about running on a MAC and eliminate the need to do the special make commands.

make binary; make install

On a MAC this should make podman-remote-darwin as bin/podman and install would do the right thing.

Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jan 29, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2021
@openshift-merge-robot openshift-merge-robot merged commit 2686e40 into containers:master Jan 29, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building and installing podman from source unavailable on macos
5 participants