Podman-remote push can support --format #9149
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
| Note: This flag can only be set when using the **dir** transport. (Not available for remote commands) | ||
| Manifest Type (oci, v2s2, or v2s1) to use when pushing an image. | ||
| Note: The **--format** flag can only be set when using the **dir** and | ||
| **docker** transports. (Not available for remote commands) |
There was a problem hiding this comment.
Was this supposed to change the "Not available for remote commands" bit as well?
There was a problem hiding this comment.
Nope. Although It now would work for them.
There was a problem hiding this comment.
If it works for remote, can we drop the comment as well?
There was a problem hiding this comment.
I think we should drop the "Note" entirely. It also works with the containers-storage transport. Others, such as docker-archive or oci or oci-archive will change the format implicitly.
There was a problem hiding this comment.
Dropped and added support for --format to podman-remote.
rhatdan
changed the title
Fix man page to document podman push --format fully. Also found that push was not handling the tlsverify so fixed this. Signed-off-by: Daniel J Walsh <[email protected]>
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Fix man page to document podman push --format fully.
Also found that push was not handling the tlsverify so fixed this.
Signed-off-by: Daniel J Walsh [email protected]