Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman generate kube ignores --network=host #9138

Merged
merged 1 commit into from
Feb 1, 2021
Merged

podman generate kube ignores --network=host #9138

merged 1 commit into from
Feb 1, 2021

Conversation

mlegenovic
Copy link
Contributor

Signed-off-by: Milivoje Legenovic [email protected]

This should solve #9077

@rhatdan
Copy link
Member

rhatdan commented Jan 28, 2021

Could you add a test?

@mlegenovic
Copy link
Contributor Author

mlegenovic commented Jan 29, 2021 •
edited
Loading

@rhatdan Added two new tests, one for pod with host network, and another one for container (without pod) with host network. Two existing tests extended with check pod.spec.hostNetwork equals false (if network-mode is not host).

@rhatdan
Copy link
Member

rhatdan commented Jan 29, 2021

Tests are failing.

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 29, 2021
@rhatdan
Copy link
Member

rhatdan commented Jan 30, 2021

LGTM
/approve
@containers/podman-maintainers PTAL

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2021
@zhangguanzhang
Copy link
Collaborator

LGTM

giuseppe
giuseppe approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, mlegenovic, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit 4ead806 into containers:master Feb 1, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe giuseppe approved these changes

Assignees

@giuseppe giuseppe

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mlegenovic @rhatdan @zhangguanzhang @openshift-ci-robot @giuseppe @openshift-merge-robot