Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List volumes before pruning #9116

Merged

Conversation

iwita
Copy link

@iwita iwita commented Jan 26, 2021

This commit lists the volumes that are going to be removed when the command podman volume prune is issued.
It is applied only in the cases when --force flag is not enabled.
Closes #8913

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2021
@rhatdan
Copy link
Member

rhatdan commented Jan 27, 2021

You are going to need to add some kind of tests.

Also could you squash your commits.

@iwita iwita force-pushed the ls-volumes-before-pruning branch 2 times, most recently from 91a5e7f to 48c05b6 Compare January 27, 2021 19:15
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any man page tweaks needed?

@iwita iwita force-pushed the ls-volumes-before-pruning branch from 48c05b6 to dc86c82 Compare January 27, 2021 22:02
@iwita iwita marked this pull request as ready for review January 28, 2021 00:29
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2021
@iwita
Copy link
Author

iwita commented Jan 28, 2021

Any man page tweaks needed?

There is an additional flag unused=0/1 added.

@rhatdan
Copy link
Member

rhatdan commented Jan 28, 2021

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jan 28, 2021

@containers/podman-maintainers PTAL

@iwita iwita force-pushed the ls-volumes-before-pruning branch from dc86c82 to 2f521b0 Compare January 28, 2021 10:44
@rhatdan
Copy link
Member

rhatdan commented Jan 29, 2021

This should go in Post 3.0 release.

@iwita
Copy link
Author

iwita commented Jan 31, 2021

Just thought that I should use the already defined filter dangling instead of creating a new one. Thus, I will update this PR.

Signed-off-by: Achilleas Tzenetopoulos <[email protected]>
@iwita iwita force-pushed the ls-volumes-before-pruning branch from 2f521b0 to 9b5b03d Compare January 31, 2021 14:32
@TomSweeneyRedHat
Copy link
Member

LGTM
should this be cherry-picked to the release-3.0 branch?

@rhatdan
Copy link
Member

rhatdan commented Feb 2, 2021

No we want this in podman 3.1
/lgtm
/approve
Thanks @iwita
Nice work.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iwita, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2021
@openshift-merge-robot openshift-merge-robot merged commit 628b0d7 into containers:master Feb 2, 2021
@iwita
Copy link
Author

iwita commented Feb 2, 2021

No we want this in podman 3.1
/lgtm
/approve
Thanks @iwita
Nice work.

@rhatdan thank you for your guidance.

@rhatdan
Copy link
Member

rhatdan commented Feb 3, 2021

Now we expect you do fix some other issues, if you want. Look for good first issues.

@iwita
Copy link
Author

iwita commented Feb 15, 2021

Now we expect you do fix some other issues, if you want. Look for good first issues.

@rhatdan Yes of course. I will check good first issues in order to find something that I could help with!

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: Let podman volume prune show the volumes that are going to be removed
5 participants