-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List volumes before pruning #9116
List volumes before pruning #9116
Conversation
You are going to need to add some kind of tests. Also could you squash your commits. |
91a5e7f
to
48c05b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any man page tweaks needed?
48c05b6
to
dc86c82
Compare
There is an additional flag |
LGTM |
@containers/podman-maintainers PTAL |
dc86c82
to
2f521b0
Compare
This should go in Post 3.0 release. |
Just thought that I should use the already defined filter |
Signed-off-by: Achilleas Tzenetopoulos <[email protected]>
2f521b0
to
9b5b03d
Compare
LGTM |
No we want this in podman 3.1 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iwita, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Now we expect you do fix some other issues, if you want. Look for good first issues. |
@rhatdan Yes of course. I will check good first issues in order to find something that I could help with! |
This commit lists the volumes that are going to be removed when the command podman volume prune is issued.
It is applied only in the cases when --force flag is not enabled.
Closes #8913