Don't fail if one of the cgroups is not setup #9110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
|
@giuseppe WDYT of this PR? |
vrothberg
reviewed
Jan 26, 2021
rhatdan
force-pushed
the
cgroups
branch
5 times, most recently
from
3d8bacd to
4974b85
Compare
vrothberg
reviewed
Jan 27, 2021
vrothberg
reviewed
Jan 27, 2021
giuseppe
reviewed
Jan 27, 2021
| } | ||
|
|
||
| var resources spec.LinuxResources | ||
| cgr, err := New("machine.slice", &resources) |
There was a problem hiding this comment.
should we check cgr is what we want?
There was a problem hiding this comment.
Sure, I was just throwing these in to keep the test checker happy. Since I don't see an easy way to test my changes.
I think it is beautiful :-) |
rhatdan
force-pushed
the
cgroups
branch
3 times, most recently
from
ae0181c to
5be13ce
Compare
|
couple nits, otherwise LGTM once tests are happy. |
It is fairly common for certain cgroups controllers to not be enabled on a system. We should Warn when this happens versus failing, when doing podman stats command. This way users can get information from the other controllers. Fixes: containers#8588 Signed-off-by: Daniel J Walsh <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is fairly common for certain cgroups controllers to
not be enabled on a system. We should Warn when this happens
versus failing, when doing podman stats command. This way users
can get information from the other controllers.
Fixes: #8588
Signed-off-by: Daniel J Walsh [email protected]