swagger.go: Fix compilation error #9080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I came across this issue while trying to update the Debian package to podman 3.0.0-rc1 |
|
How do you I that without force-pushing to my branch?
…On Sun, Jan 24, 2021 at 4:52 PM Paul Holzinger ***@***.***> wrote:
@siretart <https://github.com/siretart> You have to add [NO TESTS NEEDED]
to your commit message to get the CI green.
It looks like the definition was moved in commit b53cb57
<b53cb57>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9080 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOKTJDHWLXBZPUJ6UFVARLS3SJALANCNFSM4WQ22RIA>
.
--
regards,
Reinhard
|
|
I think a force push is required. |
Error looks like: # github.com/containers/podman/pkg/api/handlers/swagger src/github.com/containers/podman/pkg/api/handlers/swagger/swagger.go:169:3: undefined: libpod.InspectVolumeData [NO TESTS NEEDED] Signed-off-by: Reinhard Tartler <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, siretart The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Very curious that we're not hitting that in the CI. It worries me a bit. FYI @containers/podman-maintainers |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Edited description just to make it more readable in GitHub.)
Error looks like:
Signed-off-by: Reinhard Tartler [email protected]