disable dnsname when --internal #9057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
baude
force-pushed
the
dnsnameinternal
branch
from
8fde1b6 to
63f984b
Compare
|
Also fixes #8483. |
|
LGTM |
Luap99
reviewed
Jan 21, 2021
|
LGTM |
baude
force-pushed
the
dnsnameinternal
branch
from
63f984b to
7f6f3dc
Compare
|
fixed up! thanks for the review @Luap99 |
baude
force-pushed
the
dnsnameinternal
branch
from
7f6f3dc to
227dd91
Compare
Luap99
reviewed
Jan 23, 2021
baude
force-pushed
the
dnsnameinternal
branch
2 times, most recently
from
f5cbaf6 to
2c01916
Compare
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
when doing a network creation, the dnsname plugin should be disabled when the --internal bool is set. a warning is displayed if this happens and docs are updated. Signed-off-by: baude <[email protected]>
baude
force-pushed
the
dnsnameinternal
branch
from
2c01916 to
393a8f0
Compare
|
/lgtm |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when doing a network creation, the dnsname plugin should be disabled
when the --internal bool is set. a warning is displayed if this
happens and docs are updated.
Fixes: containers/dnsname#51
Signed-off-by: baude [email protected]