Ensure the Volumes field in Compat Create is honored #9025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Apparently it is not a safe assumption that |
mheon
force-pushed
the
add_support_volumes_field
branch
5 times, most recently
from
5dc7ab2 to
31ec311
Compare
|
Looks like your test is failing. |
|
It is actually a different test that was broken by the addition of my test, which is confusing since I do clean up everything. I will take another look today. |
mheon
force-pushed
the
add_support_volumes_field
branch
2 times, most recently
from
d993562 to
97203c0
Compare
Docker has, for unclear reasons, three separate fields in their Create Container struct in which volumes can be placed. Right now we support two of those - Binds and Mounts, which (roughly) correspond to `-v` and `--mount` respectively. Unfortunately, we did not support the third, `Volumes`, which is used for anonymous named volumes created by `-v` (e.g. `-v /test`). It seems that volumes listed here are *not* included in the remaining two from my investigation, so it should be safe to just append them into our handling of the `Binds` (`-v`) field. Fixes containers#8649 Signed-off-by: Matthew Heon <[email protected]>
mheon
force-pushed
the
add_support_volumes_field
branch
from
97203c0 to
1ae410d
Compare
|
Looks like this is going to go green - @containers/podman-maintainers PTAL |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker has, for unclear reasons, three separate fields in their Create Container struct in which volumes can be placed. Right now we support two of those - Binds and Mounts, which (roughly) correspond to
-vand--mountrespectively. Unfortunately, we did not support the third,Volumes, which is used for anonymous named volumes created by-v(e.g.-v /test). It seems that volumes listed here are not included in the remaining two from my investigation, so it should be safe to just append them into our handling of theBinds(-v) field.Fixes #8649