[v3.0] runner.sh : deal with bash 'set -e' #9013
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
edsantiago
changed the title
Release trigger script failed[1] because the entire script runs under 'set -e'; so a 'grep -- -dev' that finds no results will cause a nonzero exit status and hence the entire script to fail. Work around that. [1] https://cirrus-ci.com/task/4541290882793472 Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
release_deal_with_set_minus_e--3.0
branch
from
986b635 to
46df46a
Compare
| @@ -210,7 +210,8 @@ function _run_release() { | |||
| bin/podman info | |||
|
|
|||
| msg "Checking podman release (or potential release) criteria." | |||
| dev=$(bin/podman info |& grep -- -dev) | |||
| # We're running under 'set -eo pipefail'; make sure this statement passes | |||
| dev=$(bin/podman info |& grep -- -dev || echo -n '') | |||
There was a problem hiding this comment.
| dev=$(bin/podman info |& grep -- -dev || echo -n '') | |
| dev=$(bin/podman info |& grep -- -dev || true ) |
There was a problem hiding this comment.
maybe this will be better
There was a problem hiding this comment.
@zhangguanzhang thank you, why do you prefer that form? I chose echo -n '' because the expression is intended as a string capture, and I wanted to make it easily clear to a maintainer that the fallthrough is an empty string. true is logically equivalent, but could make a future maintainer stop to think it through. (At least, that was my thinking earlier today, and I still think it holds). What do you like about the true form?
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Release trigger script failed[1] because the entire script
runs under 'set -e'; so a 'grep -- -dev' that finds no
results will cause a nonzero exit status and hence the
entire script to fail. Work around that.
[1] https://cirrus-ci.com/task/4541290882793472
Signed-off-by: Ed Santiago [email protected]