Fix problems reported by staticcheck #8947
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
LGTM once comments addressed |
`staticcheck` is a golang code analysis tool. https://staticcheck.io/ This commit fixes a lot of problems found in our code. Common problems are: - unnecessary use of fmt.Sprintf - duplicated imports with different names - unnecessary check that a key exists before a delete call There are still a lot of reported problems in the test files but I have not looked at those. Signed-off-by: Paul Holzinger <[email protected]>
| @@ -48,7 +48,7 @@ func verifyContainerResourcesCgroupV1(s *specgen.SpecGenerator) ([]string, error | |||
| warnings = append(warnings, "Your kernel does not support memory swappiness capabilities, or the cgroup is not mounted. Memory swappiness discarded.") | |||
| memory.Swappiness = nil | |||
| } else { | |||
| if *memory.Swappiness < 0 || *memory.Swappiness > 100 { | |||
There was a problem hiding this comment.
Why is the less than zero check removed?
There was a problem hiding this comment.
The swappiness type is uint64 and therefore cannot be less than zero.
There was a problem hiding this comment.
I'd just be concerned that someone somewhere down the road decided to change the variable to a signed int. I'd keep the check unless it causes real headaches. Others may have differing opinions.
There was a problem hiding this comment.
Swappiness is defined here. It is part of the OCI runtime specification. I highly doubt that this will ever be changed to a signed integer.
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
staticcheckis a golang code analysis tool. https://staticcheck.io/This commit fixes a lot of problems found in our code. Common problems are:
There are still a lot of reported problems in the test files but I have
not looked at those.