Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable seccomp by default when creating a privileged container. #8863

Conversation

mgoltzsche
Copy link
Contributor

@mgoltzsche mgoltzsche commented Jan 1, 2021

When running a privileged container and SeccompProfilePath is empty no seccomp profile should be applied.
(Previously this was the case only if SeccompProfilePath was set to a non-empty default path.)

Closes #8849

When running a privileged container and `SeccompProfilePath` is empty no seccomp profile should be applied.
(Previously this was the case only if `SeccompProfilePath` was set to a non-empty default path.)

Closes containers#8849

Signed-off-by: Max Goltzsche <[email protected]>
@mgoltzsche mgoltzsche force-pushed the fix_seccomp_when_privileged branch from 7065f6d to bd35792 Compare January 2, 2021 00:39
@mgoltzsche mgoltzsche changed the title Disable seccomp when path empty and privileged. Disable seccomp by default when creating a privileged container. Jan 2, 2021
@rhatdan
Copy link
Member

rhatdan commented Jan 2, 2021

LGTM

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, mgoltzsche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2021
@openshift-merge-robot openshift-merge-robot merged commit 8e4d19d into containers:master Jan 4, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
5 participants