play kube: fix args/command handling #8807
Conversation
when neither yaml.Args nor yaml.Command are specified, we should use the entrypoint and cmd from the image. update the tests to cover this and another case (both args and command are specified). use the registry image instead of redis, as it has both an entrypoint and command specified. update the documentation around this handling to hopefully prevent regressions and confusion. Signed-off-by: Peter Hunt <[email protected]>
|
lgtm |
|
/approve |
openshift-ci-robot
added
the
approved
|
this does not use the spec's entrypoint ( PS: I am guessing it has more implications. Like signal handling. |
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
it seems to be a more invasive change of behavior to start using entrypoint. I'm investigating that now |
I will address this in a follow up, it may need more conversation /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, haircommander, zhangguanzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Not sure what is going on here. Manually merging. |
|
This bug is quiet a severe break of functionality, can this PR be backported for v2.2.2? |
|
We are doing RC1 for podman 3.0 today. |
github-actions
bot
added
the
locked - please file new issue/PR
when neither yaml.Args nor yaml.Command are specified, we should use the entrypoint and cmd from the image.
update the tests to cover this and another case (both args and command are specified).
use the registry image instead of redis, as it has both an entrypoint and command specified.
update the documentation around this handling to hopefully prevent regressions and confusion.
fixes #8803
Signed-off-by: Peter Hunt [email protected]