Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pod filter for ps #8804

Merged
merged 1 commit into from
Dec 23, 2020
Merged

add pod filter for ps #8804

merged 1 commit into from
Dec 23, 2020

Conversation

baude
Copy link
Member

@baude baude commented Dec 22, 2020

adds the ability to filter containers based on the filter "pod". the
value can be a pod name or its full or partial id.

Fixes: #8512

Signed-off-by: baude [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2020
@rhatdan
Copy link
Member

rhatdan commented Dec 22, 2020

LGTM

Luap99
Luap99 reviewed Dec 22, 2020
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit otherwise LGTM

pkg/api/server/register_containers.go Outdated Show resolved Hide resolved
@baude
add pod filter for ps
c50c754 
adds the ability to filter containers based on the filter "pod".  the
value can be a pod name or its full or partial id.

Fixes: containers#8512

Signed-off-by: baude <[email protected]>
@Luap99
Copy link
Member

Luap99 commented Dec 22, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2020
@rhatdan
Copy link
Member

rhatdan commented Dec 23, 2020

CI System seems to be hung. Forcing merge.

@rhatdan rhatdan merged commit 767e1ac into containers:master Dec 23, 2020
@edsantiago edsantiago mentioned this pull request Jan 14, 2021
Closed
@baude baude deleted the issue8512 branch May 18, 2022 15:18
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

Assignees

@Luap99 Luap99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Podman ps don't accept --filter pod
4 participants
@baude @openshift-ci-robot @rhatdan @Luap99