-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build for mips architecture #8797
Fix build for mips architecture #8797
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is there a way to cross build on these platforms to make sure we don't regress? |
I don't know. The normal cross compile with go does not work because of c dependencies so I assume we would need a mips vm. |
what about this issue #8768 |
|
The signal SIGSTKFLT does not exists on mips architectures. Also RTMIN and RTMAX are different. This code is copied from docker. Signed-off-by: Paul Holzinger <[email protected]>
ade28a7
to
1ad7966
Compare
@dangowrt Thanks for checking. This should be fixed now. |
@Luap99 Ok, just checking. These issues tend to creep in over time. |
/lgtm |
The signal SIGSTKFLT does not exists on mips architectures.
Also RTMIN and RTMAX are different.
This code is copied from docker.
Fixes #8782
Signed-off-by: Paul Holzinger [email protected]