Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for mips architecture #8797

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Dec 21, 2020

The signal SIGSTKFLT does not exists on mips architectures.
Also RTMIN and RTMAX are different.

This code is copied from docker.

Fixes #8782

Signed-off-by: Paul Holzinger [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2020
@rhatdan
Copy link
Member

rhatdan commented Dec 21, 2020

Is there a way to cross build on these platforms to make sure we don't regress?
LGTM

@Luap99
Copy link
Member Author

Luap99 commented Dec 21, 2020

I don't know. The normal cross compile with go does not work because of c dependencies so I assume we would need a mips vm.

@zhangguanzhang
Copy link
Collaborator

what about this issue #8768

@dangowrt
Copy link

Building targets
github.com/containers/psgo/internal/dev
github.com/containers/podman/v2/pkg/signal
# github.com/containers/psgo/internal/dev
../../../../../dl/go-mod-cache/github.com/containers/[email protected]/internal/dev/tty.go:116:22: cannot use s.Rdev (type uint32) as type uint64 in argument to minDevNum
../../../../../dl/go-mod-cache/github.com/containers/[email protected]/internal/dev/tty.go:117:22: cannot use s.Rdev (type uint32) as type uint64 in argument to majDevNum
# github.com/containers/podman/v2/pkg/signal
../../pkg/signal/signal_common.go:20:13: undefined: signalMap
../../pkg/signal/signal_common.go:35:20: undefined: signalMap
../../pkg/signal/signal_linux_mipsx.go:95:42: undefined: signalMap
../../pkg/signal/signal_linux_mipsx.go:96:20: undefined: signalMap

Makefile:75: recipe for target '/home/build/build_dir/build_dir/target-mips_24kc_musl/podman-2.2.1/.built' failed
make[2]: *** [/home/build/build_dir/build_dir/target-mips_24kc_musl/podman-2.2.1/.built] Error 2

The signal SIGSTKFLT does not exists on mips architectures.
Also RTMIN and RTMAX are different.

This code is copied from docker.

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99
Copy link
Member Author

Luap99 commented Dec 21, 2020

@dangowrt Thanks for checking. This should be fixed now.

@rhatdan
Copy link
Member

rhatdan commented Dec 21, 2020

@Luap99 Ok, just checking. These issues tend to creep in over time.

@baude
Copy link
Member

baude commented Dec 22, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit cfdb8fb into containers:master Dec 22, 2020
@Luap99 Luap99 deleted the fix-mips-build branch January 6, 2021 22:33
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build fails on MIPS systems
7 participants