Set NetNS mode instead of value

[bziemons]

Set NetNS mode instead of value when HostNetwork is true in the pod spec.
Also propagate whether host network namespace should be used for containers.

Closes #8790

[mheon]

LGTM, good catch
/approve

[zhangguanzhang]

need add a test for it

[bziemons]

need add a test for it

Will look into testing, but go and this project is all new to me so I wont promise anything.

[rhatdan]

I think it is time that this function take a struct, instead of constantly adding params. Not for this PR, But this function is too big.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bziemons, mheon, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mheon,rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

/lgtm
/hold

[rhatdan]

This PR is failing tests.

[bziemons]

True, the test needs to be skipped when running rootless. Will push a fix tomorrow.

[bziemons]

On second thought that is not true. podman run --network host works rootless and I just tested this change on Fedora 33 successfully as a user. Can somebody help with understanding the test's problem? The error message is very generic and is what I got before I passed the network NSMode of host down to the pod's containers.

PS: For reference, this is the kube.yaml I used for testing:

# Generation of Kubernetes YAML is still under development!
#
# Save the output of this file and use kubectl create -f to import
# it into Kubernetes.
#
# Created with podman-2.2.1
apiVersion: v1
kind: Pod
metadata:
  creationTimestamp: "2020-12-22T00:08:39Z"
  labels:
    app: distractedjemison
  name: distracted_jemison
spec:
  restartPolicy: Never
  hostNetwork: true
  containers:
  - command:
    - ip
    - a
    env:
    - name: PATH
      value: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
    - name: TERM
      value: xterm
    - name: container
      value: podman
    - name: HOSTNAME
      value: xeto
    image: quay.io/libpod/alpine
    name: distractedjemison
    resources: {}
    securityContext:
      allowPrivilegeEscalation: true
      capabilities:
        drop:
        - CAP_MKNOD
        - CAP_NET_RAW
        - CAP_AUDIT_WRITE
      privileged: false
      readOnlyRootFilesystem: false
      seLinuxOptions: {}
    workingDir: /
status: {}
---
metadata:
  creationTimestamp: null
spec: {}
status:
  loadBalancer: {}

[zhangguanzhang]

need rebase the commits to one commit

[zhangguanzhang]

need rebase all the commits to one commit😁

[bziemons]

you mean squash them together? Doesn't make sense to me, but fine.

[zhangguanzhang]

They are related, so they need to be in the same commit

[bziemons]

So I have found the problem.. It seems to be a limitation on runc, since I cannot run

podman --runtime runc run --pod "$(podman --runtime runc pod create --network host)" --rm -it quay.io/libpod/alpine ip a

It results in the same error (but also results in an error when run as root). This works fine on crun though, which was the default for me on Fedora 32. I will therefor exclude everything except crun for the HostNetwork test (as done for other tests).

[rhatdan]

/lgtm

[rhatdan]

/hold cancel