Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use entrypoint and cmd for play kube #8789

Closed
wants to merge 1 commit into from

Conversation

bziemons
Copy link
Contributor

The image's ENTRYPOINT and CMD were not handled correctly and overriding them in the container yaml specification was not supported for the entrypoint (called command as the Kubernetes field, see https://kubernetes.io/docs/tasks/inject-data-application/define-command-argument-container/#notes).
If I haven't overlooked anything, this PR should implement the scheme in the link above.

Closes #8428

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bziemons
To complete the pull request process, please assign jwhonce after the PR has been reviewed.
You can assign the PR to them by writing /assign @jwhonce in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The image's ENTRYPOINT and CMD were not handled correctly
and overriding them in the container yaml specification was not supported
for the entrypoint (called `command` as the Kubernetes field,
see https://kubernetes.io/docs/tasks/inject-data-application/define-command-argument-container/#notes).

Signed-off-by: Benedikt Ziemons <[email protected]>
@bziemons bziemons force-pushed the patch-kube-play-8428 branch from 5e02a9b to 35eca02 Compare December 20, 2020 15:43
@oleastre
Copy link

This is probably a duplicate of #8666.

@bziemons
Copy link
Contributor Author

This is probably a duplicate of #8666.

thanks for the heads-up. I wasn't aware of that because it doesn't mention the issue #8428. This was a quick fix for me so I do not mind if this just gets closed. I haven't touched the tests yet and they seem to expect something else. I have however rolled this change out to my server to not hang behind on a rolling distro.

@rhatdan rhatdan closed this Dec 21, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman play kube bin/sh syntax error
4 participants