Docker compat API - /images/search returns wrong structure (#7857) #8758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM
…On Wed, Dec 16, 2020 at 6:57 PM OpenShift CI Robot ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *NOT APPROVED*
This pull-request has been approved by: *mlegenovic
<#8758#>*
To complete the pull request process
<https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process>,
please assign *baude* after the PR has been reviewed.
You can assign the PR to them by writing /assign @baude in a comment when
ready.
The full list of commands accepted by this bot can be found here
<https://go.k8s.io/bot-commands?repo=containers%2Fpodman>.
Needs approval from an approver in each of these files:
- *OWNERS <https://github.com/containers/podman/blob/master/OWNERS>*
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8758 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3AOCD2DWSLSULJUWTNXQLSVFCNLANCNFSM4U6YE3JQ>
.
|
Luap99
reviewed
Dec 17, 2020
| @@ -77,5 +78,18 @@ func SearchImages(w http.ResponseWriter, r *http.Request) { | |||
| utils.BadRequest(w, "term", query.Term, err) | |||
| return | |||
| } | |||
| utils.WriteResponse(w, http.StatusOK, results) | |||
|
|
|||
| compatResults := []registry.SearchResult{} | |||
There was a problem hiding this comment.
Suggested change
| compatResults := []registry.SearchResult{} | |
| compatResults := make([]registry.SearchResult,0,len(results)) |
You should preallocate memory for the slice to reduce the memory copy operations.
|
LGTM with @Luap99 change. |
Signed-off-by: Milivoje Legenovic <[email protected]>
|
@containers/podman-maintainers PTAL |
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlegenovic, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Milivoje Legenovic [email protected]