Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wrong img name used when creating a container from an image which had multi names #8690

Merged

Conversation

zhangguanzhang
Copy link
Collaborator

Fixes: #8547

Signed-off-by: zhangguanzhang [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhangguanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2020
@zhangguanzhang zhangguanzhang changed the title Fix Wrong image tag is used when creating a container from an image w… Fix Wrong image name is used when creating a container from an image w… Dec 11, 2020
@zhangguanzhang zhangguanzhang changed the title Fix Wrong image name is used when creating a container from an image w… Fix Wrong image name used when creating a container from an image w… Dec 11, 2020
@zhangguanzhang zhangguanzhang changed the title Fix Wrong image name used when creating a container from an image w… Fix Wrong img name used when creating a container from an image which had multi names Dec 11, 2020
@mheon
Copy link
Member

mheon commented Dec 11, 2020

LGTM

@rhatdan
Copy link
Member

rhatdan commented Dec 11, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2020
@openshift-merge-robot openshift-merge-robot merged commit 99ac30a into containers:master Dec 11, 2020
@zhangguanzhang zhangguanzhang deleted the apiv2-wrong-ImgName branch December 12, 2020 08:17
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong image tag is used when creating a container from an image with multiple tags
5 participants