Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make podman play use ENVs from image #8654

Merged
merged 1 commit into from
Dec 9, 2020
Merged

make podman play use ENVs from image #8654

merged 1 commit into from
Dec 9, 2020

Conversation

cruwe
Copy link
Contributor

@cruwe cruwe commented Dec 9, 2020

Closes #8608

@zhangguanzhang
Copy link
Collaborator

git commit messages should sign , and should add some test units

@cruwe
make podman play use ENVs from image
b13ae2b 
fixes containers#8608.

Signed-off-by: Christopher J. Ruwe <[email protected]>
@cruwe cruwe force-pushed the cjr/bugfix-8608-take-envs-from-img branch from 917fb87 to b13ae2b Compare December 9, 2020 09:04
@cruwe
Copy link
Contributor Author

cruwe commented Dec 9, 2020 •
edited
Loading

@zhangguanzhang : added signed-off. Yes, I completely agree that the feature could use some unit tests. The breaking change from 2.1 to 2.2 would probably not have happened then. I myself, however, do not understand the test framework sufficiently, so I do not feel confident to do that correctly. I just would like to have podman play back to the working state it was in in 2.1.

@rhatdan
Copy link
Member

rhatdan commented Dec 9, 2020

thanks @cruwe
LGTM

giuseppe
giuseppe approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cruwe, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2020
@openshift-merge-robot openshift-merge-robot merged commit ae7f601 into containers:master Dec 9, 2020
@zhangguanzhang zhangguanzhang mentioned this pull request Dec 9, 2020
Closed
@rhatdan rhatdan mentioned this pull request Dec 15, 2020
Closed
@oleastre oleastre mentioned this pull request Dec 20, 2020
Closed
@vquemener vquemener mentioned this pull request Feb 22, 2021
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe giuseppe approved these changes

Assignees

@giuseppe giuseppe

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podman-rootless 2.2 eats ENV variables from the packaging process
6 participants
@cruwe @zhangguanzhang @rhatdan @openshift-ci-robot @giuseppe @openshift-merge-robot