Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor the --layers flag #8653

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Honor the --layers flag #8653

merged 1 commit into from
Dec 9, 2020

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Dec 8, 2020

Currently the --layers flag set by the user is ignored, and only the BUILDAH_LAYERS
environment variable being set is observed.

Fixes: #8643

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2020
@TomSweeneyRedHat
Copy link
Member

Looks like you've some test adjustments to make or somethings not right with the fix.

[+0204s] not ok 78 podman build --layers test failed.

@rhatdan
Honor the --layers flag
0154f9e 
Currently the --layers flag set by the user is ignored, and only the BUILDAH_LAYERS
environment variable being set is observed.

Fixes: containers#8643

Signed-off-by: Daniel J Walsh <[email protected]>
@TomSweeneyRedHat
Copy link
Member

Still some unhappy tests.
I want to dig at this more later today, I seem to recall there was some special handling needed for layers, but perhaps it was squash?

@rhatdan
Copy link
Member Author

rhatdan commented Dec 9, 2020

@TomSweeneyRedHat Last one looks like a flake. tests are passing.
@containers/podman-maintainers PTAL

giuseppe
giuseppe approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ashley-cui
ashley-cui reviewed Dec 9, 2020
View reviewed changes
Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QiWang19
Copy link
Contributor

QiWang19 commented Dec 9, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2020
@QiWang19
Copy link
Contributor

QiWang19 commented Dec 9, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2020
@openshift-merge-robot openshift-merge-robot merged commit 6db3e9b into containers:master Dec 9, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashley-cui ashley-cui ashley-cui left review comments

@giuseppe giuseppe giuseppe approved these changes

Assignees

@QiWang19 QiWang19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

disabling of layers in builds (squash) is not respected
7 participants
@rhatdan @TomSweeneyRedHat @openshift-ci-robot @QiWang19 @giuseppe @ashley-cui @openshift-merge-robot