Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix network ls --filter invalid value flake #8639

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Fix network ls --filter invalid value flake #8639

merged 1 commit into from
Dec 7, 2020
+7 −1

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Dec 7, 2020

The filter is only validated when at least one network exists.

Fix network ls --filter invalid value flake
4d6f958 
The filter is only validated when at least one network exists.

Signed-off-by: Paul Holzinger <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2020
@Luap99
Copy link
Member Author

Luap99 commented Dec 7, 2020

Example failed log: https://storage.googleapis.com/cirrus-ci-6707778565701632-fcae48/artifacts/containers/podman/4709062841466880/html/int-podman-fedora-32-rootless-host.log.html

@rhatdan
Copy link
Member

rhatdan commented Dec 7, 2020

LGTM

1 similar comment
@mheon
Copy link
Member

mheon commented Dec 7, 2020

LGTM

@rhatdan
Copy link
Member

rhatdan commented Dec 7, 2020

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2020
@Luap99
Copy link
Member Author

Luap99 commented Dec 7, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2020
@openshift-merge-robot openshift-merge-robot merged commit e2f9120 into containers:master Dec 7, 2020
@Luap99 Luap99 deleted the fix-network-ls-filter-flake branch January 2, 2021 20:18
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Luap99 @openshift-ci-robot @rhatdan @mheon @openshift-merge-robot