Pass full NetworkMode to ParseNetworkNamespace #8638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/hold
|
This looks more correct on first glance. I think discarding the error is probably wrong, we should at least be logging it. |
|
Thanks @kwiesmueller LGTM |
This should create the correct namespace for NetworkModes like container:containerid Signed-off-by: Kevin Wiesmueller <[email protected]>
kwiesmueller
force-pushed
the
fix-container-network-mode
branch
from
42fbfe3 to
af74d01
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, kwiesmueller The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a container using a docker client pointed to the compat api, setting the HostConfig.NetworkMode to something like
container:8a16f7abf12aee67342f3e5a9323c6ec33e70ac2e6365c8e4866a45a5b80478dthere is an error returned:After looking at the code, it seems like https://github.com/kwiesmueller/podman/blob/master/pkg/specgen/namespaces.go#L284 checks for the passed in
nsto have acontainer:prefix. But theNetworkMode.NetworkName()method only returnscontainer.Note that this fix is probably wrong, it solved it for me locally but I'm not familiar enough with what's going on yet and what this might cause.
/hold