add static ip to kube play

[mier85]

Signed-off-by: Michael Ernst [email protected]

this is implementing #8442

tried running lint & validate & tests, but they all failed before and after my commit. ( even tried the gate which is still partially in the CONTRIBUE.md but then realized that this seems to be no longer a thing )

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mier85
To complete the pull request process, please assign mheon after the PR has been reviewed.
You can assign the PR to them by writing /assign @mheon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zhangguanzhang]

Lack of documentation and unit tests in https://github.com/containers/podman/blob/master/test/e2e/play_kube_test.go

[mier85]

@zhangguanzhang I will add the documentation in https://github.com/containers/podman/blob/master/docs/source/markdown/podman-play-kube.1.md and some unit tests in the file you pointed to.

[zhangguanzhang]

👌

[Luap99]

Thanks for the contribution @mier85

I left some comment to simplify this a bit.

podman play kube can be run via the api and podman-remote. So you also need to add this option to the api and remote client.

The api parameter is defined here: https://github.com/containers/podman/blob/0c2a43b99db8a4fd75412a277da6de2731017d3e/pkg/api/handlers/libpod/play.go

Documentation for the api parameter has to be added here: https://github.com/containers/podman/blob/0c2a43b99db8a4fd75412a277da6de2731017d3e/pkg/api/server/register_play.go

Parameter for the remote client has to be added here: https://github.com/containers/podman/blob/master/pkg/bindings/play/play.go

[Luap99]

Not needed see other comment

[mier85]

flags will make things much easier, will update that

[Luap99]

You can just use an IP flag. No need for the extra parsing logic

Suggested change

	staticIPFlagName := "ip"
	flags.StringVar(&kubeOptions.StaticIPCLI, staticIPFlagName, "", "Static IP address to assign to this pod")
	_ = kubeCmd.RegisterFlagCompletionFunc(staticIPFlagName, completion.AutocompleteDefault)
	staticIPFlagName := "ip"
	flags.IPVar(&kubeOptions.StaticIP, staticIPFlagName, nil, "Static IP address to assign to this pod")
	_ = kubeCmd.RegisterFlagCompletionFunc(staticIPFlagName, completion.AutocompleteNone)

[Luap99]

Not needed see other comment

[github-actions]

A friendly reminder that this PR had no activity for 30 days.

[rhatdan]

@mier85 Still working on this? We need to get this in by next week, for the 3.0 release, if we are going to get it done.

[mier85]

@rhatdan still working on it. Will try to get this done ASAP this week.

But I have a question. As several Pods could be spawned when deploying ( e.g. replicas in a kubernetes manifest ) , a single static IP wouldn't work. In this case, should be assign a range starting with the IP or should we fail and ask for several IPs or should this be a "single container only" option?

[rhatdan]

I am no kubernetes expert, but I would figure fail would be the correct thing to do.

[mheon]

Making static IPs incompatible with Deployments, at least initially, sounds like a fine solution.

[hoonetorg]

@mier85: i see it that way:
if kubernetes yaml is of type pod, only one pod will be deployed. if the kind is deployment and replicas is one, also only one pod will be deployed. that are two valid scenarios for play kube, where a static ip would make sense.
the thing with the range is probably a bit too difficult for the initial shot.

[vrothberg]

Friendly ping. Are we good to continue?

[rhatdan]

@umohnani8 Could you take this one over?

[openshift-ci-robot]

@mier85: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Luap99]

Replaced by #10043