Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jira RUN-1106 Container handlers updates #8584

Merged

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Dec 3, 2020

Mostly audit and minor changes to nil from ""

Audit:

  • GET /containers/json ListContainers
  • POST /containers/create CreateContainer
  • GET /containers/{id}/json GetContainer
  • GET /containers/{id}/top TopContainer
  • GET /containers/{id}/logs LogsFromContainer
  • GET /containers/{id}/changes Changes
  • GET /containers/{id}/export ExportContainer
  • GET /containers/{id}/stats StatsContainer
  • POST /containers/{id}/resize ResizeTTY
  • POST /containers/{id}/start StartContainer
  • POST /containers/{id}/stop StopContainer
  • POST /containers/{id}/restart RestartContainer
  • POST /containers/{id}/kill KillContainer
  • POST /containers/{id}/update 404 not supported
  • POST /containers/{id}/rename 404 not supported
  • POST /containers/{id}/pause PauseContainer
  • POST /containers/{id}/unpause UnpauseContainer
  • POST /containers/{id}/attach AttachContainer
  • GET /containers/{id}/attach/ws 404 not supported
  • POST /containers/{id}/wait WaitContainer
  • DELETE /containers/{id} RemoveContainer
  • HEAD /containers/{id}/archive Archive
  • GET /containers/{id}/archive Archive
  • PUT /containers/{id}/archive Archive
  • POST /containers/prune PruneContainers

Images etc PR's will follow.

Signed-off-by: Jhon Honce [email protected]

Mostly audit and minor changes to nil from ""

Audit:
- GET /containers/json ListContainers
- POST /containers/create CreateContainer
- GET /containers/{id}/json GetContainer
- GET /containers/{id}/top TopContainer
- GET /containers/{id}/logs LogsFromContainer
- GET /containers/{id}/changes Changes
- GET /containers/{id}/export ExportContainer
- GET /containers/{id}/stats StatsContainer
- POST /containers/{id}/resize ResizeTTY
- POST /containers/{id}/start StartContainer
- POST /containers/{id}/stop StopContainer
- POST /containers/{id}/restart RestartContainer
- POST /containers/{id}/kill KillContainer
- POST /containers/{id}/update 404 not supported
- POST /containers/{id}/rename 404 not supported
- POST /containers/{id}/pause PauseContainer
- POST /containers/{id}/unpause UnpauseContainer
- POST /containers/{id}/attach AttachContainer
- GET /containers/{id}/attach/ws 404 not supported
- POST /containers/{id}/wait WaitContainer
- DELETE /containers/{id} RemoveContainer
- HEAD /containers/{id}/archive Archive
- GET /containers/{id}/archive Archive
- PUT /containers/{id}/archive Archive
- POST /containers/prune PruneContainers

Images etc PR's will follow.

Signed-off-by: Jhon Honce <[email protected]>
@jwhonce jwhonce added kind/cleanup Categorizes issue or PR as related to cleanup. 3.0 Features labels Dec 3, 2020
@jwhonce jwhonce requested review from baude and vrothberg December 3, 2020 20:54
@jwhonce jwhonce self-assigned this Dec 3, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2020
@mheon
Copy link
Member

mheon commented Dec 4, 2020

LGTM

2 similar comments
@umohnani8
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2020
@openshift-merge-robot openshift-merge-robot merged commit a2d536e into containers:master Dec 4, 2020
@jwhonce jwhonce deleted the jira/RUN-1106-containers branch December 4, 2020 16:22
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleanup. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants