Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack/podman-socat captures the API stream #8565

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Dec 2, 2020

  • verify socat and podman binaries exist
  • setup a sandboxed podman service
  • run podman service with socat proxy to capture API stream
  • clean up sandbox leaving the log files for review

Signed-off-by: Jhon Honce [email protected]

@jwhonce jwhonce added the kind/cleanup Categorizes issue or PR as related to cleanup. label Dec 2, 2020
@jwhonce jwhonce requested a review from baude December 2, 2020 22:33
@jwhonce jwhonce self-assigned this Dec 2, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020
* verify socat and podman binaries exist
* setup a sandboxed podman service
* run podman service with socat proxy to capture API stream
* clean up sandbox leaving the log files for review

Signed-off-by: Jhon Honce <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Dec 2, 2020

LGTM

@TomSweeneyRedHat
Copy link
Member

LGTM
but tests look a bit upset and I'd like a @baude head nod

@baude
Copy link
Member

baude commented Dec 3, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020
@openshift-merge-robot openshift-merge-robot merged commit c675d8a into containers:master Dec 3, 2020
@jwhonce jwhonce deleted the wip/testing branch June 30, 2021 16:12
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleanup. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants