Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add compose regression to ci #8553

Merged
merged 4 commits into from
Dec 12, 2020
Merged

add compose regression to ci #8553

merged 4 commits into from
Dec 12, 2020

Conversation

baude
Copy link
Member

@baude baude commented Dec 2, 2020

to prevent any regressionsm, we should be running regression tests using
compose.

Signed-off-by: baude [email protected]

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020
@baude baude force-pushed the composeci branch 5 times, most recently from ed56de1 to 53a3379 Compare December 10, 2020 18:09
@cevich
Copy link
Member

cevich commented Dec 10, 2020

With my new images this seems to be causing this test to fail almost universally:

Podman pod create 
           podman run --add-host in pod
           /var/tmp/go/src/github.com/containers/podman/test/e2e/pod_infra_container_test.go:379
         
         [BeforeEach] Podman pod create
           /var/tmp/go/src/github.com/containers/podman/test/e2e/pod_infra_container_test.go:19
         [It] podman run --add-host in pod
           /var/tmp/go/src/github.com/containers/podman/test/e2e/pod_infra_container_test.go:379
         Running: podman [options] pod create
         7dcd641b352967b92a3d4129821f7b10f189113f360fdd2f7bf3f403eebf7eed
         Running: podman [options] run --pod 7dcd641b352967b92a3d4129821f7b10f189113f360fdd2f7bf3f403eebf7eed --add-host foobar:127.0.0.1 quay.io/libpod/alpine:latest ping -c 1 foobar
         ping: permission denied (are you root?)
         PING foobar (127.0.0.1): 56 data bytes
         output: PING foobar (127.0.0.1): 56 data bytes

Exit code: 1

@baude baude changed the title [WIP]add compose regression to ci add compose regression to ci Dec 11, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2020
edsantiago and others added 3 commits December 11, 2020 09:23
@edsantiago @baude
WIP: test docker-compose
47af0af 
git-fetch a set of docker-compose examples

Add a mechanism for 'curl'ing to verify that service is up.

For each docker-compose directory:
  1) test that it comes up
  2) use 'curl' to confirm that the service is up
  3) bring it back down

Signed-off-by: Ed Santiago <[email protected]>
@baude
add compose regression to ci
82d7b9f 
to prevent any regressions, we should be running regression tests using
compose.

Signed-off-by: baude <[email protected]>
@edsantiago @baude
test-compose: rewrite to new subdir form
f3e69d7 
...in which we use all-local tests

Signed-off-by: Ed Santiago <[email protected]>
@baude
add compose test descriptions
cb91bf9 
adding compose test descriptions and validations.

Signed-off-by: baude <[email protected]>
@cevich
Copy link
Member

cevich commented Dec 11, 2020

Took a quick peek, this looks really good!

@edsantiago Q: I didn't check the system-tests, but it seems there are a number of "helper" functions here that may be duplicates? De-duplicating these things later can be a PITA, based on my experience. Maybe consider if makes sense to arrange for helper-code sharing early rather than later?

@rhatdan
Copy link
Member

rhatdan commented Dec 12, 2020

I am going to merge. @edsantiago Please do deduplication if you agree with @cevich in future PRs.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2020
@rhatdan
Copy link
Member

rhatdan commented Dec 12, 2020

Great work @baude and @edsantiago Now we can start talking about Compose support and any bugs we fix, we can add to these tests to prevent regressions.

@openshift-merge-robot openshift-merge-robot merged commit a226e6e into containers:master Dec 12, 2020
@cevich
Copy link
Member

cevich commented Dec 14, 2020

I second that, really nice work for something that's been a (literal) FAQ for a really long time.

@baude baude deleted the composeci branch May 18, 2022 15:18
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@baude @openshift-ci-robot @cevich @rhatdan @openshift-merge-robot @edsantiago