Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in tests #8542

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Fix typo in tests #8542

merged 1 commit into from
Dec 1, 2020

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Dec 1, 2020

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2020
@rhatdan
Copy link
Member Author

rhatdan commented Dec 1, 2020

My goal today is to make @edsantiago life a little happier.

@edsantiago
Copy link
Member

Looks great, thank you!

@umohnani8
Copy link
Member

LGTM

@edsantiago
Copy link
Member

Looks like you missed test/utils (podmansession_test.go and utils.go)

Signed-off-by: Daniel J Walsh <[email protected]>
@TomSweeneyRedHat
Copy link
Member

LGTM
and happy green test buttons

@rhatdan rhatdan added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@openshift-merge-robot openshift-merge-robot merged commit b2cd6e0 into containers:master Dec 1, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants