Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not validate the volume source path in specgen #8481

Merged

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Nov 25, 2020

The volume src path should not be validated in specgen since
the remote client also uses that part and the path must only
exists on the server. This now fails later and only on the
server and not the client.

I don't think I can add a test for this because the CI runs
server and client always on the same vm.

Fixes #8473

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you add a test for it?

@Luap99
Copy link
Member Author

Luap99 commented Nov 25, 2020

@vrothberg I don't think I can. This will only fail if server and client are not on the same machine. AFAIK this is not the case in the CI VMs?

@rhatdan
Copy link
Member

rhatdan commented Nov 25, 2020

Does this still fail, if the source volume does not exists? And does the error look decent.

@Luap99
Copy link
Member Author

Luap99 commented Nov 25, 2020

This was the old error: Error: error checking path "/test1": stat /test1: no such file or directory
And this is the new: Error: statfs /test1: no such file or directory
I think this is fine since the first error message was redundant anyway.

@rhatdan
Copy link
Member

rhatdan commented Nov 25, 2020

Excellent, I like removing stuttering errors.

@rhatdan
Copy link
Member

rhatdan commented Nov 25, 2020

LGTM
Now if we can just get quay.io to be a little less sick, we could get the tests to run.

@TomSweeneyRedHat
Copy link
Member

LGTM
assuming the tests get hip

@rhatdan
Copy link
Member

rhatdan commented Nov 25, 2020

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020
@rhatdan
Copy link
Member

rhatdan commented Nov 26, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2020
The volume src path should not be validated in specgen since
the remote client also uses that part and the path must only
exists on the server. This now fails later and only on the
server and not the client.

I don't think I can add a test for this because the CI runs
server and client always on the same vm.

Fixes containers#8473

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99 Luap99 force-pushed the fix-remote-volume-path branch from 300dd60 to f7f85fe Compare November 26, 2020 11:56
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2020
@Luap99
Copy link
Member Author

Luap99 commented Nov 26, 2020

OK, fixed the test were the host path is empty.

@rhatdan
Copy link
Member

rhatdan commented Nov 26, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2020
@rhatdan
Copy link
Member

rhatdan commented Nov 26, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2020
@openshift-merge-robot openshift-merge-robot merged commit 5af0266 into containers:master Nov 26, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With remote service, podman run --mount complains that path does not exist on client.
6 participants