-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not validate the volume source path in specgen #8481
Do not validate the volume source path in specgen #8481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you add a test for it?
@vrothberg I don't think I can. This will only fail if server and client are not on the same machine. AFAIK this is not the case in the CI VMs? |
Does this still fail, if the source volume does not exists? And does the error look decent. |
This was the old error: |
Excellent, I like removing stuttering errors. |
LGTM |
LGTM |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The volume src path should not be validated in specgen since the remote client also uses that part and the path must only exists on the server. This now fails later and only on the server and not the client. I don't think I can add a test for this because the CI runs server and client always on the same vm. Fixes containers#8473 Signed-off-by: Paul Holzinger <[email protected]>
300dd60
to
f7f85fe
Compare
OK, fixed the test were the host path is empty. |
/lgtm |
/hold cancel |
The volume src path should not be validated in specgen since
the remote client also uses that part and the path must only
exists on the server. This now fails later and only on the
server and not the client.
I don't think I can add a test for this because the CI runs
server and client always on the same vm.
Fixes #8473