[wip] allow static ip and mac with rootless cni network #8469
Conversation
Make sure we pass the ip and mac address as CNI_ARGS to the cnitool which is executed in the rootless-cni-infra container. Signed-off-by: Paul Holzinger <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| exit 1 | ||
| fi | ||
|
|
||
| ID="$1" | ||
| NET="$2" | ||
| K8S_POD_NAME="$3" | ||
| IP="$4" |
There was a problem hiding this comment.
Setting a static MAC but not a static IP is allowed - my Bash isn't good enough to know if this supports that, though.
There was a problem hiding this comment.
Yes that works but it requires #8467 for test
| @@ -25,7 +25,7 @@ import ( | |||
|
|
|||
| // Built from ../contrib/rootless-cni-infra. | |||
| var rootlessCNIInfraImage = map[string]string{ | |||
| "amd64": "quay.io/libpod/rootless-cni-infra@sha256:304742d5d221211df4ec672807a5842ff11e3729c50bc424ea0cea858f69d7b7", // 3-amd64 | |||
| "amd64": "quay.io/luap99/rootless-cni-infra@sha256:4e9f1e223463a46d9f9b019c0fa8c902494ed34872f75104d985b23812f19683", // 4-amd64 | |||
There was a problem hiding this comment.
Somebody needs to build the new image and upload it to the libpod repo. After that I can add it here.
There was a problem hiding this comment.
@TomSweeneyRedHat is this something you can do?
|
Changes LGTM |
rhatdan
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
link to #7842 |
|
A friendly reminder that this PR had no activity for 30 days. |
|
Closed in favor of #8585 |
github-actions
bot
added
the
locked - please file new issue/PR
Make sure we pass the ip and mac address as CNI_ARGS to
the cnitool which is executed in the rootless-cni-infra container.