Remove varlink support from podman #8400

rhatdan · 2020-11-18T21:14:45Z

Signed-off-by: Daniel J Walsh [email protected]

openshift-ci-robot · 2020-11-18T21:14:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rhatdan · 2020-11-18T21:17:04Z

$ ls -l -l /usr/bin/podman-remote bin/podman-remote 
-rwxrwxr-x. 1 dwalsh dwalsh 28888456 Nov 18 16:15 bin/podman-remote
-rwxr-xr-x. 1 root   root   37147440 Nov 18 16:15 /usr/bin/podman-remote
$ du -sm bin/podman-remote /usr/bin/podman-remote 
28	bin/podman-remote
36	/usr/bin/podman-remote

This helps with podman-remote's diet. After stripping binary, we see about a 33% smaller executable.

rhatdan · 2020-11-18T21:18:53Z

I am not sure if I am doing something wrong, but stripped bin/podman is a lot smaller also.

 du -sm bin/podman /usr/bin/podman
36	bin/podman
44	/usr/bin/podman
$ ls -l bin/podman /usr/bin/podman
-rwxrwxr-x. 1 dwalsh dwalsh 36744712 Nov 18 16:17 bin/podman
-rwxr-xr-x. 1 root   root   46088552 Nov 18 16:17 /usr/bin/podman

rhatdan · 2020-11-18T21:21:30Z

@baude @mheon @jwhonce PTAL
@containers/podman-maintainers PTAL
This can not be merged until we branch for podman 3.0.

mheon · 2020-11-18T21:27:06Z

I do not expect us branching master, but rather moving 2.2 development into a branch once release happens.

mheon · 2020-11-18T21:27:42Z

README.md

@@ -176,12 +176,6 @@ you to manage and maintain those images and containers in a production environme
 familiar container cli commands.  For more details, see the
 [Container Tools Guide](https://github.com/containers/buildah/tree/master/docs/containertools).

-## Podman Legacy API (Varlink)


We should leave this in with a pointer to the last supported release

Added back with a rewording.

TomSweeneyRedHat · 2020-11-18T21:32:57Z

README.md

-for remote management of containers. However, this API has been deprecated by the REST API.
-Varlink support is in maintenance mode, and will be removed in a future release.
-For more details, you can see [this blog](https://podman.io/blogs/2020/01/17/podman-new-api.html).
-


I think it would be better to keep this, but rework it: Perhaps

## Podman Legacy API (Varlink) Podman offered a [Varlink-based API](https://github.com/containers/podman/blob/master/docs/tutorials/varlink_remote_client.md) for remote management of containers in versions prior to Podman v3.0. However, this API has now been removed upstream and in Podman v3.0. For more details, you can see [this blog](https://podman.io/blogs/2020/01/17/podman-new-api.html) and [this blog](https://podman.io/blogs/2020/08/01/deprecate-and-remove-varlink-notice.html).

TomSweeneyRedHat

The code changes LGTM. I'd be fine with adding verbiage to docs saying varlink has been removed in v3.0 and only usable for prior versions. I don't think we should remove the docs entirely though. Varlink will be limping along in RHEL 8.2 and other places longer than we'd probably like.

TomSweeneyRedHat · 2020-11-18T21:39:10Z

docs/tutorials/varlink_remote_client.md

-# Podman varlink remote-client tutorial [DEPRECATED]
-
-## What is the varlink client
-


I'd keep this, but add something like:

### **NOTE:** as of Podman v3.0 the varlink client has been removed and is only usable in versions prior to Podman v3.0.

People may still use v2.0 for a while (RHEL 8.2 and earlier) and will want to get to this.

baude · 2020-11-18T21:55:25Z

i added the WIP to the title to avoid it from being accidently merged until 2.2 is done. Also, no fair! I think about three of us wanted to do this PR! Maybe we get the kill shot with the /lgtm when it is time.

TomSweeneyRedHat · 2020-11-18T23:02:17Z

Note to self and others, I need to send a notification to the Podman mailing list telling people of varlinks removal. I know this will plan in RHEL 8.4, Fedora wise it will be part of Fedora 34 and available to install for 32 and 33?

jwhonce

Small cleanups

jwhonce · 2020-11-18T23:47:23Z

go.mod

@@ -57,7 +57,7 @@ require (
 	github.com/syndtr/gocapability v0.0.0-20180916011248-d98352740cb2
 	github.com/uber/jaeger-client-go v2.25.0+incompatible
 	github.com/uber/jaeger-lib v2.2.0+incompatible // indirect
-	github.com/varlink/go v0.0.0-20190502142041-0f1d566d194b
+	github.com/varlink/go v0.4.0


Suggested change

github.com/varlink/go v0.4.0

jwhonce · 2020-11-18T23:47:53Z

go.sum

+github.com/varlink/go v0.4.0 h1:+/BQoUO9eJK/+MTSHwFcJch7TMsb6N6Dqp6g0qaXXRo=
+github.com/varlink/go v0.4.0/go.mod h1:DKg9Y2ctoNkesREGAEak58l+jOC6JU2aqZvUYs5DynU=


Suggested change

github.com/varlink/go v0.4.0 h1:+/BQoUO9eJK/+MTSHwFcJch7TMsb6N6Dqp6g0qaXXRo=

github.com/varlink/go v0.4.0/go.mod h1:DKg9Y2ctoNkesREGAEak58l+jOC6JU2aqZvUYs5DynU=

jwhonce · 2020-11-18T23:49:44Z

vendor/modules.txt

@@ -549,9 +549,8 @@ github.com/ulikunitz/xz
 github.com/ulikunitz/xz/internal/hash
 github.com/ulikunitz/xz/internal/xlog
 github.com/ulikunitz/xz/lzma
-# github.com/varlink/go v0.0.0-20190502142041-0f1d566d194b
+# github.com/varlink/go v0.4.0


Suggested change

# github.com/varlink/go v0.4.0

vrothberg

Fair well, old friend.

rhatdan · 2020-11-19T14:53:15Z

@cevich @baude I seemed to screw up the testing in .cirrus. I removed the endpoint testing and now it does not seem to be testing?

cevich · 2020-11-19T15:39:55Z

I seemed to screw up the testing in .cirrus. I removed the endpoint testing

A quick initial glance has me as puzzled as perhaps you are - It appears you did everything right 😕 Normally Cirrus-CI is much more noisy about a bad .cirrus.yml. Perhaps something coincident and unrelated is going on. Investigating...

cevich · 2020-11-19T15:43:17Z

...Yep, something on the Cirrus-CI end seems screwed up. The job triggered, but never did anything.. When I've seen similar "weird" behavior like this in the past, it's been due to outages/failures in Cirrus's GKE (kube) infrastructure (like nodes failing). Let me see if I can re-trigger a build via the API, but I've never done this before. The fastest thing is likely (and annoyingly) to push a change (like a rebase) to the PR.

cevich · 2020-11-19T16:18:32Z

Well the good news is, I was able to successfully re-trigger the original build through the Cirrus-CI API. The bad news is, it didn't do anything 😆 I'll try again but with a "create" build call as opposed to a "Retrigger" call...

cevich · 2020-11-19T16:25:12Z

Ha! it worked!

cevich · 2020-11-19T17:23:15Z

aww dang...it almost worked. fatal: Could not parse object '84131e2484f0df4ef6a1b37a1d2ce47b6e1ed3af'.

Signed-off-by: Daniel J Walsh <[email protected]>

rhatdan · 2020-12-01T13:31:42Z

@baude @mheon @vrothberg @TomSweeneyRedHat @jwhonce @ashley-cui PTAL.
Let's pull the trigger on this one and say goodbye to varlink.
@containers/podman-maintainers PTAL

vrothberg

LGTM

TomSweeneyRedHat · 2020-12-01T14:24:55Z

LGTM
So long and thanks for all the fish Varlink!
I'd \lgtm it, but I can't steal that pleasure from @mheon.

mheon · 2020-12-01T14:28:09Z

/lgtm

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2020

rhatdan added the 3.0 Features label Nov 18, 2020

mheon reviewed Nov 18, 2020

View reviewed changes

TomSweeneyRedHat reviewed Nov 18, 2020

View reviewed changes

edsantiago changed the title ~~Remove valink support from podman~~ Remove varlink support from podman Nov 18, 2020

rhatdan force-pushed the varlink branch 3 times, most recently from 2bc3a05 to 70b6599 Compare November 18, 2020 21:41

TomSweeneyRedHat reviewed Nov 18, 2020

View reviewed changes

baude changed the title ~~Remove varlink support from podman~~ [WIP]Remove varlink support from podman Nov 18, 2020

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2020

rhatdan force-pushed the varlink branch from 70b6599 to 16cceac Compare November 18, 2020 23:43

jwhonce reviewed Nov 18, 2020

View reviewed changes

rhatdan force-pushed the varlink branch 2 times, most recently from b771104 to 84131e2 Compare November 19, 2020 00:05

vrothberg reviewed Nov 19, 2020

View reviewed changes

rhatdan force-pushed the varlink branch from 84131e2 to 574faaf Compare November 26, 2020 11:21

rhatdan force-pushed the varlink branch from 574faaf to ce43df3 Compare November 26, 2020 12:51

Remove varlink support from Podman

f62a356

Signed-off-by: Daniel J Walsh <[email protected]>

rhatdan force-pushed the varlink branch from ce43df3 to f62a356 Compare November 26, 2020 21:50

rhatdan changed the title ~~[WIP]Remove varlink support from podman~~ Remove varlink support from podman Nov 26, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2020

vrothberg reviewed Dec 1, 2020

View reviewed changes

openshift-ci-robot assigned mheon Dec 1, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020

openshift-merge-robot merged commit e3f0b7d into containers:master Dec 1, 2020

github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023

github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove varlink support from podman #8400

Remove varlink support from podman #8400

rhatdan commented Nov 18, 2020

openshift-ci-robot commented Nov 18, 2020

rhatdan commented Nov 18, 2020

rhatdan commented Nov 18, 2020

rhatdan commented Nov 18, 2020

mheon commented Nov 18, 2020

mheon Nov 18, 2020

rhatdan Nov 18, 2020

TomSweeneyRedHat Nov 18, 2020

rhatdan Nov 18, 2020

TomSweeneyRedHat left a comment

TomSweeneyRedHat Nov 18, 2020

baude commented Nov 18, 2020

TomSweeneyRedHat commented Nov 18, 2020

jwhonce left a comment

jwhonce Nov 18, 2020

jwhonce Nov 18, 2020

jwhonce Nov 18, 2020

vrothberg left a comment

rhatdan commented Nov 19, 2020

cevich commented Nov 19, 2020

cevich commented Nov 19, 2020

cevich commented Nov 19, 2020

cevich commented Nov 19, 2020

cevich commented Nov 19, 2020

rhatdan commented Dec 1, 2020

vrothberg left a comment

TomSweeneyRedHat commented Dec 1, 2020

mheon commented Dec 1, 2020

		# Podman varlink remote-client tutorial [DEPRECATED]

		## What is the varlink client

		github.com/varlink/go v0.4.0 h1:+/BQoUO9eJK/+MTSHwFcJch7TMsb6N6Dqp6g0qaXXRo=
		github.com/varlink/go v0.4.0/go.mod h1:DKg9Y2ctoNkesREGAEak58l+jOC6JU2aqZvUYs5DynU=

Remove varlink support from podman #8400

Remove varlink support from podman #8400

Conversation

rhatdan commented Nov 18, 2020

openshift-ci-robot commented Nov 18, 2020

rhatdan commented Nov 18, 2020

rhatdan commented Nov 18, 2020

rhatdan commented Nov 18, 2020

mheon commented Nov 18, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

baude commented Nov 18, 2020

TomSweeneyRedHat commented Nov 18, 2020

jwhonce left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vrothberg left a comment

Choose a reason for hiding this comment

rhatdan commented Nov 19, 2020

cevich commented Nov 19, 2020

cevich commented Nov 19, 2020

cevich commented Nov 19, 2020

cevich commented Nov 19, 2020

cevich commented Nov 19, 2020

rhatdan commented Dec 1, 2020

vrothberg left a comment

Choose a reason for hiding this comment

TomSweeneyRedHat commented Dec 1, 2020

mheon commented Dec 1, 2020