Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Add support for pod inside of user namespace. #8393

Closed
wants to merge 1 commit into from
Closed

[wip] Add support for pod inside of user namespace. #8393

wants to merge 1 commit into from

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Nov 18, 2020

Specifically we need to be able to launch a pod with
--userns=keep-id

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2020
@rhatdan rhatdan changed the title Add support for pod inside of user namespace. [wip] Add support for pod inside of user namespace. Nov 18, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2020
@rhatdan rhatdan mentioned this pull request Nov 23, 2020
Closed
@rhatdan
Copy link
Member Author

rhatdan commented Nov 23, 2020

Fixes: #7706

@rhatdan
Add support for pod inside of user namespace.
3798cb7 
Specifically we need to be able to launch a pod with
--userns=keep-id

Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan rhatdan mentioned this pull request Dec 18, 2020
Closed
@rhatdan
Copy link
Member Author

rhatdan commented Dec 18, 2020

@umohnani8 Could you take this over? I don't have the time to complete it.

@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@rhatdan
Copy link
Member Author

rhatdan commented Jan 18, 2021

@umohnani8 Do you have a chance to take this over?

@rhatdan rhatdan removed the stale-pr label Jan 18, 2021
@rhatdan
Copy link
Member Author

rhatdan commented Jan 18, 2021

The basic issue, we are seeing is people adding containers to pods where they use additional fields that do not match the pods infra container.

For example we have an issue where a user creates a pod, and then adds a container to the pod, within a user namespace, and the /dev/mqueue from the infra container fails to mount on the container, because the /dev/mqueue inside of the pod does not match the usernamespace inside of the container.

Bottom line, I believe we have to be able to at least configure the usernamespace of the pod.

@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@rhatdan rhatdan removed the stale-pr label Feb 18, 2021
@chengscott chengscott mentioned this pull request Feb 22, 2021
Closed
@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@umohnani8
Copy link
Member

Will be taking over this work.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2021
@openshift-ci-robot
Copy link
Collaborator

@rhatdan: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@rhatdan rhatdan removed the stale-pr label May 13, 2021
@umohnani8
Copy link
Member

Replaced by #10589

@umohnani8 umohnani8 closed this Jun 7, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhatdan @openshift-ci-robot @umohnani8