Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix podman images... missing headers in table templates #8392

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Fix podman images... missing headers in table templates #8392

merged 1 commit into from
Dec 2, 2020
+13 −6

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Nov 18, 2020

Signed-off-by: Jhon Honce [email protected]

@jwhonce jwhonce added the kind/cleanup Categorizes issue or PR as related to cleanup. label Nov 18, 2020
@jwhonce jwhonce self-assigned this Nov 18, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2020
@jwhonce jwhonce force-pushed the wip/report branch 2 times, most recently from adc281e to e5bcb6f Compare November 18, 2020 18:03
@rhatdan
Copy link
Member

rhatdan commented Nov 18, 2020

LGTM

1 similar comment
@mheon
Copy link
Member

mheon commented Nov 18, 2020

LGTM

ashley-cui
ashley-cui reviewed Nov 18, 2020
View reviewed changes
Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashley-cui
Copy link
Member

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2020
@rhatdan
Copy link
Member

rhatdan commented Nov 18, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2020
@mheon
Copy link
Member

mheon commented Nov 18, 2020

Tests appear very angry

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2020
@zhangguanzhang
Copy link
Collaborator

this broke this:

         # # podman-remote --url unix:/tmp/podman.vkaVWN images --sort repository --format table {{.Repository}} {{.Tag}} {{.ID}}
         # REPOSITORY                      TAG              IMAGE ID
         # a.b/c                           d                766ff5a3a7e4
         # quay.io/libpod/testimage        20200929         766ff5a3a7e4
         # zzzzzzzzzz.yyyyyyyyy/xxxxxxxxx  QTaFGG7HKApGQX8  766ff5a3a7e4
         # #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
         # #|     FAIL: podman images, table, line 0
         # #| expected: 'a.b/c                           d                766ff5a3a7e4'
         # #|   actual: 'REPOSITORY                      TAG              IMAGE ID'

@baude
Copy link
Member

baude commented Dec 2, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@jwhonce
Copy link
Member Author

jwhonce commented Dec 2, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2020
@openshift-merge-robot openshift-merge-robot merged commit d456765 into containers:master Dec 2, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashley-cui ashley-cui ashley-cui left review comments

@ParkerVR ParkerVR Awaiting requested review from ParkerVR

Assignees

@jwhonce jwhonce

@rhatdan rhatdan

@baude baude

@ashley-cui ashley-cui

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleanup. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jwhonce @openshift-ci-robot @rhatdan @mheon @ashley-cui @zhangguanzhang @baude @openshift-merge-robot