Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:DOCS] Fix example for manifest push #8382

Merged
merged 1 commit into from
Nov 18, 2020
Merged

[CI:DOCS] Fix example for manifest push #8382

merged 1 commit into from
Nov 18, 2020

Conversation

dbaker-arch
Copy link
Contributor

Updating the "podman manifest push" example to match the required syntax.

If you run the command as stated:

  • Error: error pushing manifest multiarch to quay.io/myimagelist: Invalid image name "quay.io/myimagelist", expected colon-separated transport:reference

@dbaker-arch
Copy link
Contributor Author

/assign @mheon

@mheon
Copy link
Member

mheon commented Nov 17, 2020

@QiWang19 PTAL

@mheon
Copy link
Member

mheon commented Nov 17, 2020

@dbaker-rh Can you add a signoff to your commit? git commit --amend -s and then a force-push should do it.

@mheon
Copy link
Member

mheon commented Nov 17, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dbaker-rh, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2020
@TomSweeneyRedHat
Copy link
Member

LGTM
assuming happy tests

@dbaker-arch
Copy link
Contributor Author

signed and re-pushed.

QiWang19
QiWang19 reviewed Nov 18, 2020
View reviewed changes
Copy link
Contributor

@QiWang19 QiWang19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QiWang19
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2020
@openshift-merge-robot openshift-merge-robot merged commit a6f7afd into containers:master Nov 18, 2020
@dbaker-arch dbaker-arch deleted the helppage branch November 18, 2020 15:28
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@QiWang19 QiWang19 QiWang19 left review comments

Assignees

@mheon mheon

@QiWang19 QiWang19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dbaker-arch @mheon @openshift-ci-robot @TomSweeneyRedHat @QiWang19 @openshift-merge-robot