Refactor to use DockerClient vs APIClient #8308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwhonce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
jwhonce
force-pushed
the
jira/run-976
branch
from
c3c3dea to
f8cd0db
Compare
jwhonce
added a commit
to jwhonce/podman
that referenced
this pull request
Nov 12, 2020
requires containers#8308 Signed-off-by: Jhon Honce <[email protected]>
jwhonce
force-pushed
the
jira/run-976
branch
from
f8cd0db to
1e55ffd
Compare
* Update tests and framework * remove tests for APIClient methods Signed-off-by: Jhon Honce <[email protected]>
jwhonce
force-pushed
the
jira/run-976
branch
from
1e55ffd to
a1187ee
Compare
|
LGTM |
|
@containers/podman-maintainers please review and merge |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to a higher level abstraction.
Signed-off-by: Jhon Honce [email protected]