Add --log-driver to play kube #8270
Merged
+38
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addresses containers#6604 Signed-off-by: Andy Librian <[email protected]>
andylibrian
commented
Nov 8, 2020
| @@ -1466,4 +1466,20 @@ MemoryReservation: {{ .HostConfig.MemoryReservation }}`}) | |||
| Expect(kube.ExitCode()).To(Equal(125)) | |||
| Expect(kube.ErrorToString()).To(ContainSubstring(invalidImageName)) | |||
| }) | |||
|
|
|||
| It("podman play kube applies log driver to containers", func() { | |||
| Skip("need to verify images have correct packages for journald") | |||
There was a problem hiding this comment.
I skip this test because the other tests related to journald are also skipped:
Line 196 in e2b82e6
|
Thanks @andylibrian |
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andylibrian, TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To integrate container/pod logs into systemd service and journalctl, we can use
--log-driver=journaldonpodman createandpodman run. Howeverplay kubedoesn't have the option yet. So, this PR adds it toplay kube.Addresses #6604