-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:DOCS] Update podman build man page to match buildah bud man page #8256
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
||
Valid _mode_ values are: | ||
|
||
Valid _mode_ values are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cut/paste error? Line 369 and 371 look to be dupes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Valid _mode_ values are: | ||
|
||
- **none**: no networking; | ||
- **host**: use the Podman host network stack. Note: the host mode gives the container full access to local system services such as D-bus and is therefore considered insecure; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- **host**: use the Podman host network stack. Note: the host mode gives the container full access to local system services such as D-bus and is therefore considered insecure; | |
- **host**: use the Podman host network stack. Note: the host mode gives the container full access to local system services such as D-bus and is therefore considered insecure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIxed
- **none**: no networking; | ||
- **host**: use the Podman host network stack. Note: the host mode gives the container full access to local system services such as D-bus and is therefore considered insecure; | ||
- **ns:**_path_: path to a network namespace to join; | ||
- `private`: create a new namespace for the container (default) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just private? I don't recall, but thought there were one or two more....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well there is private, none, host and ns. There is also container: for podman run, but this does not work with build.
|
||
- **none**: no networking; | ||
- **host**: use the Podman host network stack. Note: the host mode gives the container full access to local system services such as D-bus and is therefore considered insecure. | ||
- **ns:**_path_: path to a network namespace to join; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
- **ns:**_path_: path to a network namespace to join; | |
- **ns:**_path_: path to a network namespace to join. |
- **none**: no networking; | ||
- **host**: use the Podman host network stack. Note: the host mode gives the container full access to local system services such as D-bus and is therefore considered insecure. | ||
- **ns:**_path_: path to a network namespace to join; | ||
- **private**: create a new namespace for the container (default) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
- **private**: create a new namespace for the container (default) | |
- **private**: create a new namespace for the container (default). |
@containers/podman-maintainers PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -188,6 +188,10 @@ The [username[:password]] to use to authenticate with the registry if required. | |||
If one or both values are not supplied, a command line prompt will appear and the | |||
value can be entered. The password is entered without echo. | |||
|
|||
**--decryption-key** *key[:passphrase]* | |||
|
|||
The [key[:passphrase]] to be used for decryption of images. Key can point to keys and/or certificates. Decryption will be tried with all keys. If the key is protected by a passphrase, it is required to be passed in the argument and omitted otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sake of consistency I recommend to keep the line break at 80 chars.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have --decryption-key until the next vendor of buildah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than Sascha's comment, LGTM
Sadly I just destroyed this PR, will attempt to fix it. |
2d0a277
to
4a910a4
Compare
Signed-off-by: Daniel J Walsh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If you are using `useradd` within your build script, you should pass the `--no-log-init or -l` option to the `useradd` command. This option tells useradd to stop creating the lastlog file. | ||
If you are using `useradd` within your build script, you should pass the | ||
`--no-log-init or -l` option to the `useradd` command. This option tells | ||
useradd to stop creating the lastlog file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also in the troubleshooting guide. I think this makes sense to leave as is here, but maybe we should add a pointer to the troubleshooting guide here too?
/lgtm |
Signed-off-by: Daniel J Walsh [email protected]