pull: account for platform #8228
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@containers/podman-maintainers PTAL @nalind, @TomSweeneyRedHat ... that's fixing the issue we chatted about yesterday |
|
The new |
Good catch. I forgot about "variant"! Is that what you were referring to? |
More vaguely than I should have, but yeah, variant. |
vrothberg
force-pushed
the
fix-8001
branch
2 times, most recently
from
1aff9c8 to
be3afae
Compare
|
Curious. Jobs didn't get queued for three hours. |
|
@vrothberg Could you rebase this and see if it passes tests? |
When pulling an image, account for the specified OS, architecture and variant when looking up local images. While a local image may be found based on the specified name, the platform may be different from what the user desires. In that case, do not use the local image but continue pulling. Also remove pull-policy logic from the client. That'll reduce one roundtrip for the remote client and reduces code scattering. The backend should be the single source of truth for pull-policy handling. Fixes: containers#8001 Signed-off-by: Valentin Rothberg <[email protected]>
|
I am currently focusing on the copy work. I will go back to this PR after. |
|
A friendly reminder that this PR had no activity for 30 days. |
|
@rhatdan was faster to fix it :) |
github-actions
bot
added
the
locked - please file new issue/PR
When pulling an image, account for the specified OS and architecture
when looking up local images. While a local image may be found based
on the specified name, the platform may be different from what the
user desires. In that case, do not use the local image but continue
pulling.
Also remove pull-policy logic from the client. That'll reduce one
roundtrip for the remote client and reduces code scattering. The
backend should be the single source of truth for pull-policy handling.
Fixes: #8001
Signed-off-by: Valentin Rothberg [email protected]