Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for host keys for non-22 ports #8141

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Add support for host keys for non-22 ports #8141

merged 1 commit into from
Oct 27, 2020

Conversation

afbjorklund
Copy link
Contributor

@afbjorklund afbjorklund commented Oct 25, 2020 •
edited
Loading

When not using the standard SSH port (22), the port is appended
to the hostname (in brackets) like so: "host" -> "[host]:1234"

Closes #8139
Rebased version of PR #8140 (for v2.1)

@afbjorklund
Add support for host keys for non-22 ports
6f6cf87 
When not using the standard SSH port (22), the port is appended
to the hostname (in brackets) like so: "host" -> "[host]:1234"

Signed-off-by: Anders F Björklund <[email protected]>
(cherry picked from commit 8794e8d)
@rhatdan
Copy link
Member

rhatdan commented Oct 25, 2020

/approve
LGTM
@containers/podman-maintainers PTAL
@jwhonce @baude PTAL

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2020
@rhatdan
Copy link
Member

rhatdan commented Oct 27, 2020

@saschagrunert @mheon @vrothberg PTAL

saschagrunert
saschagrunert approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, rhatdan, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vrothberg
vrothberg reviewed Oct 27, 2020
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Let's wait for a head nod from @jwhonce before merging.

@TomSweeneyRedHat
Copy link
Member

LGTM

@jwhonce
Copy link
Member

jwhonce commented Oct 27, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2020
@openshift-merge-robot openshift-merge-robot merged commit ee29328 into containers:master Oct 27, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees

@jwhonce jwhonce

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Host key validation doesn't work when not using port 22
8 participants
@afbjorklund @rhatdan @openshift-ci-robot @TomSweeneyRedHat @jwhonce @saschagrunert @vrothberg @openshift-merge-robot