add GitHub action to add non-main branch to PR title #8138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a GitHub action to add the name of the target branch as prefix to the title of a pull request. It is easy to miss the target of a given pull request which has already caused issues of commits going into non-main branches without intention. We have already used this action on the `v2.0.5-rhel` branch with limited success. Fortunately, the upstream implemented our feature request to support adding the _target_ branch name (rather than the source) to the PR title, which is what we need. Any non-main branch from this commit forward will now be clearly marked. Signed-off-by: Valentin Rothberg <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@containers/podman-maintainers PTAL I set up a test branch and a test PR against it in #8137. Note that we should delete the testing branch |
|
@nalind @TomSweeneyRedHat @mtrmac feel free to pick this up for Buildah, Skopeo, c/image and c/storage if you desire such check. |
|
LGTM
…On Sun, Oct 25, 2020, 06:37 Valentin Rothberg ***@***.***> wrote:
@nalind <https://github.com/nalind> @TomSweeneyRedHat
<https://github.com/TomSweeneyRedHat> @mtrmac <https://github.com/mtrmac>
feel free to pick this up for Buildah, Skopeo, c/image and c/storage if you
desire such check.
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#8138 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3AOCAOQNUABXPG44NDU73SMP5XRANCNFSM4S6HTOWQ>
.
|
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a GitHub action to add the name of the target branch as prefix to
the title of a pull request. It is easy to miss the target of a given
pull request which has already caused issues of commits going into
non-main branches without intention.
We have already used this action on the
v2.0.5-rhelbranch withlimited success. Fortunately, the upstream implemented our feature
request to support adding the target branch name (rather than the
source) to the PR title, which is what we need.
Any non-main branch from this commit forward will now be clearly marked.
Signed-off-by: Valentin Rothberg [email protected]