container create: record correct image name #8098
Conversation
Record the correct image name when creating a container by using the resolved image name if present. Otherwise, default to using the first available name or an empty string in which case the image must have been referenced by ID. Fixes: containers#8082 Signed-off-by: Valentin Rothberg <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
| @@ -473,4 +473,23 @@ json-file | f | |||
| run_podman kill $cid | |||
| } | |||
|
|
|||
| # Regression test for issue #8082 | |||
| @test "podman run : look up correct image name" { | |||
|
LGTM |
| @@ -469,7 +469,7 @@ func (ir *Runtime) getLocalImage(inputName string) (string, *storage.Image, erro | |||
| if err != nil { | |||
| return "", nil, err | |||
| } | |||
| img, err := ir.store.Image(ref.String()) | |||
| img, err := ir.store.Image(reference.TagNameOnly(ref).String()) | |||
There was a problem hiding this comment.
@baude @mheon ... this should have a quite positive effect on container creation. If the user input wasn't tagged or digested, this lookup always failed, so we fell back to looking at all tags of all images (below in the code).
Now, we normalize to ":latest" which should have a noticeable performance boost on nodes with many images. It's also fixed in the short-names PR but it was necessary to get this fix working as well.
|
@containers/podman-maintainers PTAL |
|
LGTM
…On Thu, Oct 22, 2020, 04:28 Valentin Rothberg ***@***.***> wrote:
@containers/podman-maintainers
<https://github.com/orgs/containers/teams/podman-maintainers> PTAL
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8098 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3AOCGW5BNEYGFMKGFN2ELSL7UMLANCNFSM4SZ4TBJA>
.
|
|
LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Record the correct image name when creating a container by using the
resolved image name if present. Otherwise, default to using the first
available name or an empty string in which case the image must have been
referenced by ID.
Fixes: #8082
Signed-off-by: Valentin Rothberg [email protected]