Add EOL to compat container logs

[crunchtime-ali]

Per request of @rhatdan I created the change mentioned by @psakar in #8058 as a pull request.

It fixes the problem that container logs provided by REST API do not contain an EOL (\n)

[crunchtime-ali]

/assign @mheon

[rhatdan]

Thanks @crunchtime-ali
Could you sign your commits.
git commit -a -s --amend
git push --force

LGTM
Should we have similar in the libpod interface?

@jwhonce @baude @containers/podman-maintainers PTAL

[mheon]

@ashley-cui PTAL

[saschagrunert]

LGTM

[vrothberg]

I think we should only do it for the compat layer:

if !utils.IsLibpodRequest(r) {
....

@ashley-cui WDYT?

[ashley-cui]

That sounds good to me, since adding the \n using the remote client results in duplicate newlines, doing it only for the compat layer would make more sense and look cleaner

[crunchtime-ali]

@vrothberg @ashley-cui do you rather want:

if utils.IsLibpodRequest(r) {
	frame.WriteString(line.Msg)
} else {
	frame.WriteString(line.Msg + "\n")
}

or

frame.WriteString(line.Msg)
if !utils.IsLibpodRequest(r) {
	frame.WriteString("\n")
}

[vrothberg]

The latter seems cleaner to me. Also please add a code comment (ideally with a link to the issue you're fixing) as well.

[crunchtime-ali]

Added and squashed @vrothberg

[rhatdan]

/lgtm
/approve
/hold
@crunchtime-ali Thanks.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crunchtime-ali, rhatdan, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[TomSweeneyRedHat]

looks like a timing issue is meeting up the works. @edsantiago is this one of your known "friends"?

[+0008s] ok 52 [01-basic] GET info : status=200
[+0008s] not ok 53 [01-basic] Time for ten /info requests
[+0008s] #  expected: <= 7 seconds
[+0008s] #    actual: 8 seconds

[TomSweeneyRedHat]

LGTM
once test gremlins are chased away

[edsantiago]

[+0008s] not ok 53 [01-basic] Time for ten /info requests - addressed in current master.

Two other failures are #8068 which @cevich claims "should retry automatically" so I'm not going to press Re-run

[jwhonce]

restarted tests, agent stopped responding

[cevich]

should retry automatically

Cirrus-CI gives you one freebie restart if the agent konks out for some reason. Anything beyond that requires pressing the button 😞

[rhatdan]

/hold cancel