APIv2 compatibility network connect|disconnect #8078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
mheon
reviewed
Oct 20, 2020
mheon
reviewed
Oct 20, 2020
mheon
reviewed
Oct 20, 2020
mheon
reviewed
Oct 20, 2020
baude
force-pushed
the
networkdisconnect
branch
2 times, most recently
from
19f6f0c to
e19cfbf
Compare
jwhonce
reviewed
Oct 21, 2020
baude
force-pushed
the
networkdisconnect
branch
from
e19cfbf to
c3f69e8
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add endpoints for the compat layer for network connect and disconnect. As of now, these two endpoints do nothing to change the network state of a container. They do some basic data verification and return the proper 200 response. This at least allows for scripts to work on the compatibility layer instead of getting 404s. Signed-off-by: baude <[email protected]>
baude
force-pushed
the
networkdisconnect
branch
from
c3f69e8 to
6841936
Compare
|
all fixed, can i get a merge or hold merge? |
mheon
reviewed
Oct 22, 2020
|
LGTM |
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add endpoints for the compat layer for network connect and disconnect. As of now, these two endpoints do nothing to change the network state of a container. They do some basic data verification and return the proper 200 response. This at least allows for scripts to work on the compatibility layer instead of getting 404s.
Signed-off-by: baude [email protected]