Always add the dnsname plugin to the config for rootless #8044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM
…On Fri, Oct 16, 2020, 06:50 Daniel J Walsh ***@***.***> wrote:
@baude <https://github.com/baude> @giuseppe <https://github.com/giuseppe>
PTAL
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8044 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3AOCFHCMKJPACLPSUHWG3SLAQOBANCNFSM4STETBFQ>
.
|
openshift-ci-robot
added
the
approved
|
Looks like a flake on the fedora-32 Build test, re-ran |
AkihiroSuda
approved these changes
Oct 17, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AkihiroSuda, giuseppe, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
The rootless-cni-infra container always has the dnsname plugin installed. It makes no sense to check if it is present on the host. Signed-off-by: Paul Holzinger <[email protected]>
|
/lgtm |
openshift-ci-robot
added
lgtm
This was referenced Oct 19, 2020
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rootless-cni-infra container always has the dnsname
plugin installed. It makes no sense to check if it is
present on the host.
Fixes #8040