Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix podman-run man page heading #8035

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Fix podman-run man page heading #8035

merged 1 commit into from
Oct 15, 2020

Conversation

xordspar0
Copy link
Contributor

Sharing IPC is meant to be an example under the Examples heading, not a
new section.

Signed-off-by: Jordan Christiansen [email protected]

Sharing IPC is meant to be an example under the Examples heading, not a
new section.

Signed-off-by: Jordan Christiansen <[email protected]>
@@ -1234,7 +1234,7 @@ you'd like to connect instead, as in:
$ podman run -a stdin -a stdout -i -t fedora /bin/bash
```

## Sharing IPC between containers
### Sharing IPC between containers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the podman create manpage to see if it also has this issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

podman create has only a few examples, and this IPC one isn't one of them. 👍

@mheon
Copy link
Member

mheon commented Oct 15, 2020

/aapprove
LGTM

@TomSweeneyRedHat
Copy link
Member

LGTM
once tests are happy and I'm assuming this change had nothing to do with this unhappiness.

@mheon
Copy link
Member

mheon commented Oct 15, 2020

Another "CI Agent Stopped Responding"

@mheon
Copy link
Member

mheon commented Oct 15, 2020

/approve
Spelling is occasionally hard

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, xordspar0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2020
@rhatdan
Copy link
Member

rhatdan commented Oct 15, 2020

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2020
@rhatdan rhatdan merged commit c3ecdd0 into containers:master Oct 15, 2020
@xordspar0 xordspar0 deleted the fix-doc-heading branch October 15, 2020 18:33
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants