Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible panic in libpod container restore #8030

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Oct 15, 2020

We need to do a length check before we can access the
networkStatus slice by index to prevent a runtime panic.

Fixes #8026

We need to do a length check before we can access the
networkStatus slice by index to prevent a runtime panic.

Fixes containers#8026

Signed-off-by: Paul Holzinger <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Oct 15, 2020

LGTM

@rhatdan
Copy link
Member

rhatdan commented Oct 15, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2020
@zhangguanzhang
Copy link
Collaborator

LGTM

@rhatdan
Copy link
Member

rhatdan commented Oct 15, 2020

/lgtm
/hold
cancel hold when tests pass.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2020
@mheon
Copy link
Member

mheon commented Oct 15, 2020

Restarted one "CI Agent Stopped Responding" flake

@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2020
@openshift-merge-robot openshift-merge-robot merged commit a82d60d into containers:master Oct 15, 2020
@Luap99 Luap99 deleted the fix-restore-panic branch November 19, 2020 20:33
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restoring a checkpoint panics (in pod with infra container)
7 participants