Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix podman image trust show --raw output #8029

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Fix podman image trust show --raw output #8029

merged 1 commit into from
Oct 16, 2020

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Oct 15, 2020

No description provided.

@Luap99
Copy link
Member Author

Luap99 commented Oct 15, 2020

@edsantiago Is this a known flake in APIv2 test?

not ok 53 [01-basic] Time for ten /info requests
#  expected: <= 7 seconds
#    actual: 8 seconds

https://storage.googleapis.com/cirrus-ci-6707778565701632-fcae48/artifacts/containers/podman/6514321641439232/html/apiv2-podman-fedora-32-root-host.log.html

@edsantiago
Copy link
Member

@Luap99 something bad is going on with the APIv2 test. The timeout used to be 5 seconds for 10 /info calls. Just this week I bumped it up to 7 seconds because the timeout was failing (6). Now it's failing (8).

The reason this test is there is that at some earlier point the API got broken, with a delay on each call. I have no way of knowing if the current breakage is a similar delay in the API or if it's a slow CI machine. @jwhonce @baude are you aware of any new API code that could've reintroduced the delay? Can you please PTAL? I will be OOTO today with no network access.

@rhatdan
Copy link
Member

rhatdan commented Oct 15, 2020

LGTM
@containers/podman-maintainers PTAL

@Luap99 Luap99 force-pushed the image-trust-show-raw branch from 667b1b2 to a261819 Compare October 15, 2020 17:05
QiWang19
QiWang19 reviewed Oct 15, 2020
View reviewed changes
Copy link
Contributor

@QiWang19 QiWang19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

saschagrunert
saschagrunert approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwhonce
Copy link
Member

jwhonce commented Oct 15, 2020

@edsantiago If memory serves @baude included more network details this week

@jwhonce
Copy link
Member

jwhonce commented Oct 15, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2020
@QiWang19
Copy link
Contributor

May need an approval label to get this merged?

@jwhonce
Copy link
Member

jwhonce commented Oct 15, 2020 •
edited
Loading

/approved

@rhatdan
Copy link
Member

rhatdan commented Oct 16, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, rhatdan, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2020
@openshift-merge-robot openshift-merge-robot merged commit fe1b6cc into containers:master Oct 16, 2020
@edsantiago edsantiago mentioned this pull request Oct 19, 2020
Closed
@Luap99 Luap99 deleted the image-trust-show-raw branch November 19, 2020 20:33
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@QiWang19 QiWang19 QiWang19 left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees

@jwhonce jwhonce

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Luap99 @edsantiago @rhatdan @jwhonce @QiWang19 @openshift-ci-robot @saschagrunert @openshift-merge-robot