Restore --format table support #7987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwhonce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
jwhonce
force-pushed
the
jira/run-898-5
branch
5 times, most recently
from
01149ed to
d6d573b
Compare
ashley-cui
reviewed
Oct 12, 2020
jwhonce
force-pushed
the
jira/run-898-5
branch
2 times, most recently
from
3b5df1a to
3e906d6
Compare
| return nil | ||
| } | ||
|
|
||
| w := tabwriter.NewWriter(os.Stdout, 0, 0, 2, ' ', 0) |
There was a problem hiding this comment.
Unless they're on top of each other, I really dislike short variable names, especially so one char ones. Searching for them is just too painful when updating/fixing two years from now.
|
LGTM besides @TomSweeneyRedHat 's comment & tests |
jwhonce
force-pushed
the
jira/run-898-5
branch
from
3e906d6 to
006dad3
Compare
* system df * events * fix error handling from go routine * update tests to use gomega matchers for better error messages * system info * version * volume inspect Signed-off-by: Jhon Honce <[email protected]>
jwhonce
force-pushed
the
jira/run-898-5
branch
from
006dad3 to
eb4a746
Compare
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jhon Honce [email protected]