Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/spec: fix a confusing error message #7984

Merged

Conversation

nalind
Copy link
Member

@nalind nalind commented Oct 9, 2020

When we try, but fail, to load the default seccomp profile, say that, instead of suggesting that we tried to load a profile with no name.

When we try, but fail, to load the default seccomp profile, say that,
instead of suggesting that we tried to load a profile with no name.

Signed-off-by: Nalin Dahyabhai <[email protected]>
@nalind nalind force-pushed the seccomp-error-message branch from 162548a to b14bffd Compare October 9, 2020 19:54
@mheon
Copy link
Member

mheon commented Oct 9, 2020

LGTM

@jwhonce
Copy link
Member

jwhonce commented Oct 9, 2020

/lgtm

pending tests...
/hold

@jwhonce
Copy link
Member

jwhonce commented Oct 9, 2020

/hold cancel

@jwhonce jwhonce closed this Oct 9, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
@jwhonce jwhonce reopened this Oct 9, 2020
@jwhonce
Copy link
Member

jwhonce commented Oct 9, 2020

/hold cancel

@jwhonce jwhonce removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2020
@TomSweeneyRedHat
Copy link
Member

LGTM

1 similar comment
@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

Looks like two of the tests were automatically canceled here? We'd weird CI problems on Bulidah today, I'm blaming @nalind for both! ;^)

@mheon
Copy link
Member

mheon commented Oct 10, 2020

/hold

Restarted the cancelled test

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2020
@rhatdan
Copy link
Member

rhatdan commented Oct 10, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nalind, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2020
@rhatdan
Copy link
Member

rhatdan commented Oct 12, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2020
@openshift-merge-robot openshift-merge-robot merged commit 717177a into containers:master Oct 12, 2020
@nalind nalind deleted the seccomp-error-message branch October 14, 2020 13:27
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants